RE: [PATCH 1/1] hv_netvsc: Allocate the receive buffer from the correct NUMA node

From: KY Srinivasan
Date: Thu May 28 2015 - 18:29:36 EST




> -----Original Message-----
> From: K. Y. Srinivasan [mailto:kys@xxxxxxxxxxxxx]
> Sent: Thursday, May 28, 2015 2:56 PM
> To: davem@xxxxxxxxxxxxx; netdev@xxxxxxxxxxxxxxx; linux-
> kernel@xxxxxxxxxxxxxxx; devel@xxxxxxxxxxxxxxxxxxxxxx; olaf@xxxxxxxxx;
> apw@xxxxxxxxxxxxx; jasowang@xxxxxxxxxx
> Cc: KY Srinivasan
> Subject: [PATCH 1/1] hv_netvsc: Allocate the receive buffer from the correct
> NUMA node
>
> Allocate the receive bufer from the NUMA node assigned to the primary
> channel.
>
> Signed-off-by: K. Y. Srinivasan <kys@xxxxxxxxxxxxx>
> ---
> drivers/net/hyperv/netvsc.c | 7 ++++++-
> 1 files changed, 6 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/hyperv/netvsc.c b/drivers/net/hyperv/netvsc.c
> index b024968..d187965 100644
> --- a/drivers/net/hyperv/netvsc.c
> +++ b/drivers/net/hyperv/netvsc.c
> @@ -227,13 +227,18 @@ static int netvsc_init_buf(struct hv_device *device)
> struct netvsc_device *net_device;
> struct nvsp_message *init_packet;
> struct net_device *ndev;
> + int node;
>
> net_device = get_outbound_net_device(device);
> if (!net_device)
> return -ENODEV;
> ndev = net_device->ndev;
>
> - net_device->recv_buf = vzalloc(net_device->recv_buf_size);
> + node = cpu_to_node(device->channel->target_cpu);
> + net_device->recv_buf = vzalloc_node(net_device->recv_buf_size,
> node);
> + if (!net_device->recv_buf)
> + net_device->recv_buf = vzalloc(net_device->recv_buf_size);
> +
> if (!net_device->recv_buf) {
> netdev_err(ndev, "unable to allocate receive "
> "buffer of size %d\n", net_device->recv_buf_size);
> --
> 1.7.4.1

David,

Please drop this patch; I am going to resend this with another patch.

Regards,

K. Y
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/