Re: [RFC v3 33/45] nfsd: Keep list of acls to dispose of in compoundargs

From: Andreas GrÃnbacher
Date: Thu May 28 2015 - 16:28:38 EST


2015-05-28 21:52 GMT+02:00 J. Bruce Fields <bfields@xxxxxxxxxxxx>:
> On Fri, Apr 24, 2015 at 01:04:30PM +0200, Andreas Gruenbacher wrote:
>> We will decode acls in requests into richacls; those need to be richacl_put()
>> at the end of the request instead of kfree()d; this allows the vfs to cache
>> them whenever possible.
>>
>> NOTE: If we allow only a single acl per request, we can get rid of the list
>> here.
>
> Technically I guess we're supposed to allow it, and maybe someday
> someone will come up with a reason.... So I'm not inclined to drop the
> list.

Okay, I'll update the comment accordingly.

Thanks,
Andreas
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/