Re: [PATCH 1/2] regulator: core: add support to get VSEL register from hw driver

From: Mark Brown
Date: Thu May 28 2015 - 09:53:20 EST


On Wed, May 27, 2015 at 08:10:20PM +0530, Laxman Dewangan wrote:

> Add callback on the regulator ops to get the voltage selection
> register address and mask from device regulator driver. Use this
> new callback in regulator_get_hardware_vsel_register().

It's not entirely clear to me that this is a good idea - the expected
use case for getting the vsel register is to hand it off to something
like a microcontroller for it to use but if the vsel register might
change at runtime then we also need infrastructure to synchronize those
changes with whatever is using the register. How does your system keep
them in sync?

Attachment: signature.asc
Description: Digital signature