Re: sched_setscheduler() vs idle_balance() race

From: Mike Galbraith
Date: Thu May 28 2015 - 08:32:56 EST


On Thu, 2015-05-28 at 14:06 +0200, Peter Zijlstra wrote:
> On Thu, May 28, 2015 at 02:04:21PM +0200, Mike Galbraith wrote:
> > On Thu, 2015-05-28 at 13:51 +0200, Peter Zijlstra wrote:
>
> > > Which is exactly the hole you mean, right?
> >
> > Yeah, but that hole is way older than dl. Box falling into it is
> > running SLE11, which is.. well, still somewhat resembles 3.0.
>
> Oh sure, that patch just recognised there was a hole there and put a
> comment in. We further failed to spot the fail you just did.

Happens. Even with a perfect trap set and triggered, evidence right
under my nose, I'm so used to that code that I didn't see the obvious
until I took a second look.. and had that 'you dumbass' moment ;-)

-Mike

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/