Re: [PATCH v8 0/3] x86/earlyprintk: setup serial earlyprintk as early as possible

From: Alexander Kuleshov
Date: Thu May 28 2015 - 04:01:27 EST


2015-05-27 18:51 GMT+06:00 Borislav Petkov <bp@xxxxxxx>:
> Now, have you tested this on real hardware? Because your 0/n message
> said "qemu" but I don't think that's sufficient. If we're going to
> enable early_printk this early, we'd need it working on real hardware
> too.
>
> For that I'd suggest adding a 4th, test patch which issues a couple of
> numbered early_printk() lines which we could run on a bunch of machines
> to see whether it actually works.

Thank you for suggestions. But how to do it? The patch already contains:

if (console_loglevel >= CONSOLE_LOGLEVEL_DEBUG)
early_printk("Early printk is initialized\n");

But I've just noticesed that it does not print anything, because
console_loglevel can be CONSOLE_LOGLEVEL_DEBUG
only after parse_early_params too :) How to better be with it? To remove
if clause and just leave early_printk or something else?

Or you meant something else about patch for testing?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/