Re: [PATCH] clockevents: timer-stm32: Fix build warning spotted by kbuild test robot

[Maxime Coquelin]

2015-05-28 0:52 GMT+02:00 Luc Van Oostenryck <luc.vanoostenryck@xxxxxxxxx>:
> On Wed, May 27, 2015 at 06:41:23PM +0200, Maxime Coquelin wrote:
>>
>>       /* Detect whether the timer is 16 or 32 bits */
>> -     writel_relaxed(~0UL, data->base + TIM_ARR);
>> +     writel_relaxed((u32)~0UL, data->base + TIM_ARR);
>>       max_delta = readl_relaxed(data->base + TIM_ARR);
>>       if (max_delta == ~0UL) {
>>               prescaler = 1;
>
>
> Since the warning come from using a unsigned long constant while
> writel() expect an unsigned int, why not simply use ~0U ?

You are right, this is indeed the right fix.
I'm sending the v2 now, using ~0U.

Thanks,
Maxime
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/