Re: [Spice-devel] [PATCH 05/11] Handle all errors in qxl_surface_evict

[Dave Airlie]

On 27 May 2015 at 20:04, Frediano Ziglio <fziglio@xxxxxxxxxx> wrote:
> Only EBUSY error was handled. This could cause code to believe
> reserve was successful while it failed.
>
> Signed-off-by: Frediano Ziglio <fziglio@xxxxxxxxxx>

This has been there since I wrote qxl, so I expect I had some reason
for it, but I can't remember it
now..

Most likely is something had the bo reserved already and we reentered
from somewhere we shouldn't
but I think a lot of the horrible code went away.

so because I can't justify the hack,
Reviewed-by: Dave Airlie <airlied@xxxxxxxxxx>
Dave.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/