Re: [PATCH 4/4] perf: Add power8 PMU events in JSON format

From: Andi Kleen
Date: Wed May 27 2015 - 12:24:56 EST


On Thu, May 28, 2015 at 12:01:31AM +0900, Namhyung Kim wrote:
> On Wed, May 27, 2015 at 11:41 PM, Andi Kleen <ak@xxxxxxxxxxxxxxx> wrote:
> >> > + {
> >> > + "EventCode": "0x2505e",
> >> > + "EventName": "PM_BACK_BR_CMPL",
> >> > + "BriefDescription": "Branch instruction completed with a target address less than current instruction address,",
> >> > + "PublicDescription": "Branch instruction completed with a target address less than current instruction address.,"
> >>
> >> Can't we remove PublicDescription field if it's identical to
> >> BriefDescription? It seems just wasting spaces..
> >
> > It's not always identical. There are events where PublicDescription is much longer (several paragraphs)
>
> I know. What I said is make it optional so that we can drop if it's identical.

Should be easy enough. It's already optional in the jevents parser.

-Andi

--
ak@xxxxxxxxxxxxxxx -- Speaking for myself only
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/