Re: [PATCH] Staging: vt6655: Remove unnecessary equality checks for a bool variable
From: Harisangam, Sharvari (S.)
Date: Wed May 27 2015 - 08:07:22 EST
On Tue, May 26, 2015 at 10:35:57AM +0530, Sudip Mukherjee wrote:
> On Mon, May 25, 2015 at 12:22:25PM +0000, Harisangam, Sharvari (S.) wrote:
> > Modified the if-else statements to remove unnecessary comparisons.
> > This change was detected with the help of coccinelle tool
> >
> > Signed-off-by: Harisangam Sharvari S <sharisan@xxxxxxxxxxx>
> you should not use initials in the Signed-off-by name. This should be
> the name which you usually use to sign any legal document.
>
> regards
> sudip
The signed off name is now changed .
-Sharvari Harisangam
From 822045c4d3c28d36b8a540520a48795fec4c7eff Mon Sep 17 00:00:00 2001
From: Harisangam Sharvari <sharisan@xxxxxxxxxxx>
Date: Mon, 25 May 2015 15:42:43 +0530
Subject: [PATCH] Staging: vt6655: Remove unnecessary equality checks for a
bool variable
Modified the if-else statements to remove unnecessary comparisons.
This change was detected with the help of coccinelle tool
Signed-off-by: Harisangam Sharvari <sharisan@xxxxxxxxxxx>
---
drivers/staging/vt6655/rxtx.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/vt6655/rxtx.c b/drivers/staging/vt6655/rxtx.c
index 7468776..7fedde3 100644
--- a/drivers/staging/vt6655/rxtx.c
+++ b/drivers/staging/vt6655/rxtx.c
@@ -1093,7 +1093,7 @@ s_cbFillTxBufHead(struct vnt_private *pDevice, unsigned char byPktType,
if (byPktType == PK_TYPE_11GB || byPktType == PK_TYPE_11GA) {/* 802.11g packet */
if (byFBOption == AUTO_FB_NONE) {
- if (bRTS == true) {/* RTS_need */
+ if (bRTS) {/* RTS_need */
pvRrvTime = (void *)(pbyTxBufferAddr + wTxBufSize);
pMICHDR = (struct vnt_mic_hdr *)(pbyTxBufferAddr + wTxBufSize + sizeof(struct vnt_rrv_time_rts));
pvRTS = (void *)(pbyTxBufferAddr + wTxBufSize + sizeof(struct vnt_rrv_time_rts) + cbMICHDR);
@@ -1115,7 +1115,7 @@ s_cbFillTxBufHead(struct vnt_private *pDevice, unsigned char byPktType,
}
} else {
/* Auto Fall Back */
- if (bRTS == true) {/* RTS_need */
+ if (bRTS) {/* RTS_need */
pvRrvTime = (void *)(pbyTxBufferAddr + wTxBufSize);
pMICHDR = (struct vnt_mic_hdr *) (pbyTxBufferAddr + wTxBufSize + sizeof(struct vnt_rrv_time_rts));
pvRTS = (void *) (pbyTxBufferAddr + wTxBufSize + sizeof(struct vnt_rrv_time_rts) + cbMICHDR);
@@ -1138,7 +1138,7 @@ s_cbFillTxBufHead(struct vnt_private *pDevice, unsigned char byPktType,
} else {/* 802.11a/b packet */
if (byFBOption == AUTO_FB_NONE) {
- if (bRTS == true) {
+ if (bRTS) {
pvRrvTime = (void *)(pbyTxBufferAddr + wTxBufSize);
pMICHDR = (struct vnt_mic_hdr *) (pbyTxBufferAddr + wTxBufSize + sizeof(struct vnt_rrv_time_ab));
pvRTS = (void *)(pbyTxBufferAddr + wTxBufSize + sizeof(struct vnt_rrv_time_ab) + cbMICHDR);
@@ -1158,7 +1158,7 @@ s_cbFillTxBufHead(struct vnt_private *pDevice, unsigned char byPktType,
}
} else {
/* Auto Fall Back */
- if (bRTS == true) { /* RTS_need */
+ if (bRTS) { /* RTS_need */
pvRrvTime = (void *)(pbyTxBufferAddr + wTxBufSize);
pMICHDR = (struct vnt_mic_hdr *) (pbyTxBufferAddr + wTxBufSize + sizeof(struct vnt_rrv_time_ab));
pvRTS = (void *)(pbyTxBufferAddr + wTxBufSize + sizeof(struct vnt_rrv_time_ab) + cbMICHDR);
--
1.7.9.5