RE: [RESEND PATCH V4 3/3] mfd: da9063: MFD support for OnKey driver

[Opensource [Steve Twiss]]

On 26 May 2015 14:58 Lee Jones wrote:

> To: Opensource [Steve Twiss]
> Cc: Samuel Ortiz; DT; David Dajun Chen; Dmitry Torokhov; INPUT; Ian
> Campbell; Kumar Gala; LKML; Mark Rutland; Pawel Moll; Rob Herring;
> Support Opensource
> Subject: Re: [RESEND PATCH V4 3/3] mfd: da9063: MFD support for OnKey
> driver
> 
> On Tue, 19 May 2015, S Twiss wrote:
> 
> > From: Steve Twiss <stwiss.opensource@xxxxxxxxxxx>
> >
> > Add MFD support for the DA9063 OnKey driver
> >
> > The function da9063_clear_fault_log() is added to mitigate the case of a
> > hardware power-cut after a long-long OnKey press. Although there is no
> > software intervention in this case (by definition) such a shutdown would
> > cause persistent information within the DA9063 FAULT_LOG that would be
> > available during the next device restart.
> >
> > Clearance of this persistent register must be completed after such a
> > hardware power-cut operation has happened so that the FAULT_LOG does not
> > continue with previous values. The clearance function has been added here
> > in the kernel driver because wiping the fault-log cannot be counted on
> > outside the Linux kernel.
> >
> > Acked-by: Lee Jones <lee.jones@xxxxxxxxxx>
> >
> > Signed-off-by: Steve Twiss <stwiss.opensource@xxxxxxxxxxx>
> >
> > ---
> > Version History
> >
> > Changes in V4
> >  - Additional description of MFD patch changes for FAULT_LOG in relation to
> >    the requirements of the OnKey driver. Please see a further explanation of
> >    the OnKey's operation in this thread: https://lkml.org/lkml/2015/4/29/406
> >
> > Changes in V3
> >  - The MFD code was originally in [PATCH V2 1/2]. This is now been moved into
> >    this patch [PATCH V3 3/3].
> >  - Whitespace cleanup
> >
> > This patch applies against linux-next and v4.1-rc3
> >
> >
> >  drivers/mfd/da9063-core.c        | 54
> ++++++++++++++++++++++++++++++++++++++++
> >  include/linux/mfd/da9063/pdata.h |  1 +
> >  2 files changed, 55 insertions(+)
> 
> Applied, thanks.
> 

Thank you
Regards,
Steve

ps.
and also for DT patch

[...]