Re: [PATCH v4 06/11] md/raid5: get rid of bio_fits_rdev()

From: Christoph Hellwig
Date: Mon May 25 2015 - 10:17:18 EST


On Mon, May 25, 2015 at 05:54:14PM +1000, NeilBrown wrote:
> Did I write that? I guess I did :-(
> I meant *after*. Don't get rid of bio_fits_rdev until split_bio is in
> chunk_aligned_read().

I suspect the whole series could use some reordering.

patch 1:

add ->bio_split and blk_queue_split

patch 2..n:

one for each non-trivial driver that implements ->merge_bvec_fn to
remove it and instead split bios in ->make_request. The md patch
to do the right thing in chunk_aligned_read goes into the general
md patch here. The bcache patch also goes into this series.

patch n+1:

- add blk_queue_split calls for remaining trivial drivers

patch n+2:

- remove ->merge_bvec_fn and checking of max_sectors a for all
drivers, simplify bio_add_page

patch n+2:

- remove splitting in blkdev_issue_discard

patch n+3

- remove bio_fits_rdev

patch n+4

- remove bio_get_nr_vecs

patch n+4

- use bio_add_page

patch n+5

- update documentation
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/