Re: [PATCH v3 1/1] usb: ulpi: ulpi_init should be executed in subsys_initcall

[Heikki Krogerus]

On Fri, May 22, 2015 at 09:08:45AM -0700, David Cohen wrote:
> Hi,
> 
> On Fri, May 22, 2015 at 07:29:15PM +0800, Lu Baolu wrote:
> > Phy drivers and the ulpi interface providers depend on the
> > registeration of the ulpi bus.  Ulpi registers the bus in
> > module_init(). This could result in a load order issue, i.e.
> 
> It's still not an issue :(
> I'd say "unnecessary probe delays".
> 
> But of cource it's Felipe's call :) Description looks better now.
> 
> BR, David
> 
> > ulpi phy drivers or the ulpi interface providers loading
> > before the bus registeration.
> > 
> > This patch fixes this load order issue by putting ulpi_init
> > in subsys_initcall().
> > 
> > Reported-by: Zhuo Qiuxu <qiuxu.zhuo@xxxxxxxxx>
> > Signed-off-by: Lu Baolu <baolu.lu@xxxxxxxxxxxxxxx>

Adding Felipe. FWIW, my ACK in any case:

Acked-by: Heikki Krogerus <heikki.krogerus@xxxxxxxxxxxxxxx>


Thanks,

-- 
heikki
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/