RE: [PATCH 1/2] f2fs: avoid duplicated code by reusing f2fs_read_end_io

[Chao Yu]

Hi Jaegeuk,

> -----Original Message-----
> From: Jaegeuk Kim [mailto:jaegeuk@xxxxxxxxxx]
> Sent: Wednesday, May 20, 2015 1:49 AM
> To: Chao Yu
> Cc: Changman Lee; linux-f2fs-devel@xxxxxxxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx
> Subject: Re: [PATCH 1/2] f2fs: avoid duplicated code by reusing f2fs_read_end_io
> 
> Hi Chao,
> 
> On Tue, May 19, 2015 at 05:38:56PM +0800, Chao Yu wrote:
> > This patch tries to clean up code as part code of f2fs_read_end_io
> > and mpage_end_io are the same, so it's better to merge and reuse them.
> >
> > Signed-off-by: Chao Yu <chao2.yu@xxxxxxxxxxx>
> > ---
> >  fs/f2fs/data.c | 35 +++++------------------------------
> >  1 file changed, 5 insertions(+), 30 deletions(-)
> >
> > diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c
> > index 8d04e24..5173d0f 100644
> > --- a/fs/f2fs/data.c
> > +++ b/fs/f2fs/data.c
> > @@ -34,40 +34,16 @@ static void f2fs_read_end_io(struct bio *bio, int err)
> >  	struct bio_vec *bvec;
> >  	int i;
> >
> > -	bio_for_each_segment_all(bvec, bio, i) {
> > -		struct page *page = bvec->bv_page;
> > -
> > -		if (!err) {
> > -			SetPageUptodate(page);
> > -		} else {
> > -			ClearPageUptodate(page);
> > -			SetPageError(page);
> > -		}
> > -		unlock_page(page);
> > -	}
> > -	bio_put(bio);
> > -}
> > -
> > -/*
> > - * I/O completion handler for multipage BIOs.
> > - * copied from fs/mpage.c
> > - */
> > -static void mpage_end_io(struct bio *bio, int err)
> > -{
> > -	struct bio_vec *bv;
> > -	int i;
> > -
> >  	if (f2fs_bio_encrypted(bio)) {
> >  		if (err) {
> >  			f2fs_release_crypto_ctx(bio->bi_private);
> >  		} else {
> > -			f2fs_end_io_crypto_work(bio->bi_private, bio);
> > -			return;
> > +			return f2fs_end_io_crypto_work(bio->bi_private, bio);
> 
> IMO, it'd better remain the previous one to make clear that
> f2fs_en_io_crypto_work defines a void return.
> How about that?

OK, will do.

Thanks,

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/