Re: [PATCH v3 1/1] usb: ulpi: ulpi_init should be executed in subsys_initcall

[Lu, Baolu]

On 05/23/2015 12:08 AM, David Cohen wrote:
> Hi,
>
> On Fri, May 22, 2015 at 07:29:15PM +0800, Lu Baolu wrote:
> > Phy drivers and the ulpi interface providers depend on the
> > registeration of the ulpi bus.  Ulpi registers the bus in
> > module_init(). This could result in a load order issue, i.e.
> It's still not an issue :(
> I'd say "unnecessary probe delays".

I managed to boot a kernel built from the top of Felipe's
remotes/origin/next branch under an Ubuntu environment
on Intel's Bay Trail tablet.

The same panic (as I found in the Android environment previously)
shows up as well. And if I replace module_init() with sys_initcall(),
the panic disappears.

Thanks,
-Baolu

> But of cource it's Felipe's call :) Description looks better now.
>
> BR, David
>
> > ulpi phy drivers or the ulpi interface providers loading
> > before the bus registeration.
> >
> > This patch fixes this load order issue by putting ulpi_init
> > in subsys_initcall().
> >
> > Reported-by: Zhuo Qiuxu <qiuxu.zhuo@xxxxxxxxx>
> > Signed-off-by: Lu Baolu <baolu.lu@xxxxxxxxxxxxxxx>
> > ---
> >   drivers/usb/common/ulpi.c | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/usb/common/ulpi.c b/drivers/usb/common/ulpi.c
> > index 0e6f968..01c0c04 100644
> > --- a/drivers/usb/common/ulpi.c
> > +++ b/drivers/usb/common/ulpi.c
> > @@ -242,7 +242,7 @@ static int __init ulpi_init(void)
> >   {
> >   	return bus_register(&ulpi_bus);
> >   }
> > -module_init(ulpi_init);
> > +subsys_initcall(ulpi_init);
> >   
> >   static void __exit ulpi_exit(void)
> >   {
> > --
> > 2.1.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/