Re: [PATCH v3 0/4] firmware: few fixes for name uses

From: Luis R. Rodriguez
Date: Tue May 19 2015 - 12:45:41 EST


On Tue, May 12, 2015 at 02:49:39PM -0700, Luis R. Rodriguez wrote:
> From: "Luis R. Rodriguez" <mcgrof@xxxxxxxx>
>
> This v3 changes patch 1 to just return -ENOMEM and remove the
> unlikely() optimization. It also drops the early truncation
> checks.
>
> Luis R. Rodriguez (4):
> firmware: fix __getname() missing failure check
> firmware: check for file truncation on direct firmware loading
> firmware: fix possible use after free on name on asynchronous request
> firmware: use const for remaining firmware names
>
> drivers/base/firmware_class.c | 61 +++++++++++++++++++++++++++++++------------
> 1 file changed, 45 insertions(+), 16 deletions(-)

Ming, a review would be much appreciated. I also have a few other changes coming
later, so should these go through Greg or Takashi first ? If its of any help
I'm happy to take on co-maintenance on this module given that I am lookng
to do quite a bit of surgery on the APIs later.

Luis
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/