Re: [PATCH 2/2] PM / sleep: Make ->enter_freeze callbacks depend on CONFIG_SUSPEND

From: Peter Zijlstra
Date: Tue May 19 2015 - 11:00:37 EST


On Mon, May 18, 2015 at 11:45:10PM +0200, Rafael J. Wysocki wrote:
> On Monday, May 18, 2015 02:18:26 PM Peter Zijlstra wrote:
> > On Sat, May 16, 2015 at 01:38:48AM +0200, Rafael J. Wysocki wrote:
> > > From: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx>
> > >
> > > The ->enter_freeze callbacks of cpuidle drivers are only used if
> > > CONFIG_SUSPEND is set, so make them explicitly depend on that
> > > Kconfig option.
> >
> > No real objection, but is it worth it to sprinkle that CONFIG stuff over
> > all drivers?
>
> Well, you maybe right that it isn't. The footprint is small anyway.
>
> What about [1/2]?

1/2 looks fine to me.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/