Re: [PATCH v3 1/3] x86/setup: introduce setup_bultin_cmdline

[Andy Shevchenko]

On Tue, 2015-05-12 at 22:14 +0600, Alexander Kuleshov wrote:
> Hi Andy,
> 
> 
> 2015-05-12 16:50 GMT+06:00 Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>:
> >
> > This one breaks kernel to work. You have to call setup_builtin_cmdline()
> > here.
> >
> >>       strlcpy(command_line, boot_command_line, COMMAND_LINE_SIZE);
> >>       *cmdline_p = command_line;
> >>
> 
> Why? The setup_builtin_cmdline will be called before setup_arch in the
> head{32, 64}.c,
> or I've missed something?

Yes, you missed the call here in *this* patch.

So, here is a trade off between smaller understandable changes and
bisectability. On one hand you may go like you did previously (one patch
for two changes), on the other â make it work after each patch applied
one-by-one.

-- 
Andy Shevchenko <andriy.shevchenko@xxxxxxxxx>
Intel Finland Oy

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/