Re: [PATCH 1/2] clone: Support passing tls argument via C rather than pt_regs magic

From: Ingo Molnar
Date: Mon May 11 2015 - 10:02:01 EST



* Josh Triplett <josh@xxxxxxxxxxxxxxxx> wrote:

> On Mon, May 11, 2015 at 12:13:13PM +0200, Ingo Molnar wrote:
> >
> > * josh@xxxxxxxxxxxxxxxx <josh@xxxxxxxxxxxxxxxx> wrote:
> >
> > > On Tue, May 05, 2015 at 08:53:03PM +0200, Thomas Gleixner wrote:
> > > > On Tue, 21 Apr 2015, Josh Triplett wrote:
> > > > >
> > > > > Signed-off-by: Josh Triplett <josh@xxxxxxxxxxxxxxxx>
> > > > > Signed-off-by: Thiago Macieira <thiago.macieira@xxxxxxxxx>
> > > >
> > > > Can you please clarify that SOB chain? It does not make any sense.
> > >
> > > Co-authored patch. We both worked on it together, and sadly git
> > > doesn't support a commit with multiple authors, so this is the next
> > > best thing.
> >
> > No, this is not a valid SOB chain.
> >
> > For 'co authored' patches you can add credits either to the file,
> > as two copyright lines, or via the changelog, no need to mess up
> > the SOB chain for that.
>
> Fine, I'll write it another way.
>
> Do you see any other issues with the patch other than the signoffs?

Looks good to me, but I have not looked very deeply ...

Thanks,

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/