Re: [PATCH 23/27] backlight: Allow compile test of GPIO consumers if !GPIOLIB

From: Lee Jones
Date: Thu May 07 2015 - 03:37:40 EST


On Tue, 05 May 2015, Geert Uytterhoeven wrote:

> The GPIO subsystem provides dummy GPIO consumer functions if GPIOLIB is
> not enabled. Hence drivers that depend on GPIOLIB, but use GPIO consumer
> functionality only, can still be compiled if GPIOLIB is not enabled.
>
> Relax the dependency on GPIOLIB if COMPILE_TEST is enabled, where
> appropriate.
>
> Signed-off-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
> Cc: Jingoo Han <jg1.han@xxxxxxxxxxx>
> Cc: Lee Jones <lee.jones@xxxxxxxxxx>
> Cc: Jean-Christophe Plagniol-Villard <plagnioj@xxxxxxxxxxxx>
> Cc: Tomi Valkeinen <tomi.valkeinen@xxxxxx>
> Cc: linux-fbdev@xxxxxxxxxxxxxxx
> ---
> drivers/video/backlight/Kconfig | 8 +++++---
> 1 file changed, 5 insertions(+), 3 deletions(-)

Looks good. Applied, thanks.

> diff --git a/drivers/video/backlight/Kconfig b/drivers/video/backlight/Kconfig
> index 2d9923a60076e380..0505b796d743250e 100644
> --- a/drivers/video/backlight/Kconfig
> +++ b/drivers/video/backlight/Kconfig
> @@ -36,14 +36,16 @@ config LCD_CORGI
>
> config LCD_L4F00242T03
> tristate "Epson L4F00242T03 LCD"
> - depends on SPI_MASTER && GPIOLIB
> + depends on SPI_MASTER
> + depends on GPIOLIB || COMPILE_TEST
> help
> SPI driver for Epson L4F00242T03. This provides basic support
> for init and powering the LCD up/down through a sysfs interface.
>
> config LCD_LMS283GF05
> tristate "Samsung LMS283GF05 LCD"
> - depends on SPI_MASTER && GPIOLIB
> + depends on SPI_MASTER
> + depends on GPIOLIB || COMPILE_TEST
> help
> SPI driver for Samsung LMS283GF05. This provides basic support
> for powering the LCD up/down through a sysfs interface.
> @@ -434,7 +436,7 @@ config BACKLIGHT_AS3711
>
> config BACKLIGHT_GPIO
> tristate "Generic GPIO based Backlight Driver"
> - depends on GPIOLIB
> + depends on GPIOLIB || COMPILE_TEST
> help
> If you have a LCD backlight adjustable by GPIO, say Y to enable
> this driver.

--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org â Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/