Re: [PATCH 3/7] x86/intel_rdt: Support cache bit mask for Intel CAT

[Vikas Shivappa]

On Wed, 6 May 2015, Peter Zijlstra wrote:

> On Mon, May 04, 2015 at 10:30:15AM -0700, Vikas Shivappa wrote:
> > Will fix the whitespace issues (including before return) or other possible
> > coding convention issues.
> >
> > It could be more of a common sense to have this in checkpatch rather that
> > manually having to pointing out. If you want to have fun with that go for it
> > though.
>
> My main objection was that your coding style is entirely inconsistent
> with itself.
>
> Sometimes you have a whitespace before return, sometimes you do not.
>
> Sometimes you have exit labels with locks, sometimes you do not.
>
> etc..
>
> Pick one stick to it; although we'd all much prefer if you pick the one
> that's common to the kernel.

Will fix the convention issues.

Thanks,
Vikas

>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/