Re: [PATCH v2] splice: sendfile() at once fails for big files

[Jens Axboe]

On 05/05/2015 09:41 PM, Linus Torvalds wrote:
> Jens, ping?
>
> The test results should make this a no-brainer, but I hate how random
> these flag ops.

Missed the original, apparently. I too am confused how this is a 
correctness fix and not just an optimization.

+               if (read_len < len)
+                       sd->flags |= SPLICE_F_MORE;
+               else if (!more)
+                       sd->flags &= ~SPLICE_F_MORE;

Should that check be for 'more', not '!more'?


--
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/