Re: [PATCH 03/10] uprobes: Send SIGILL if handle_trampoline() fails

[Srikar Dronamraju]

* Oleg Nesterov <oleg@xxxxxxxxxx> [2015-05-04 14:48:58]:

> 1. It doesn't make sense to continue if handle_trampoline() fails,
>    change handle_swbp() to always return after this call.
> 
> 2. Turn pr_warn() into uprobe_warn(), and change handle_trampoline()
>    to send SIGILL on failure. It is pointless to return to user mode
>    with the corrupted instruction_pointer() which we can't restore.

I agree

> 
> Signed-off-by: Oleg Nesterov <oleg@xxxxxxxxxx>
> ---

Acked-by: Srikar Dronamraju <srikar@xxxxxxxxxxxxxxxxxx>
-- 
Thanks and Regards
Srikar Dronamraju

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/