Re: [PATCH v2] hypervisor/x86/xen: Unset X86_BUG_SYSRET_SS_ATTRS on Xen PV guests

From: Boris Ostrovsky
Date: Tue May 05 2015 - 13:33:45 EST


On 05/05/2015 01:25 PM, David Vrabel wrote:
On 04/05/15 16:02, Boris Ostrovsky wrote:
--- a/arch/x86/xen/enlighten.c
+++ b/arch/x86/xen/enlighten.c
@@ -1760,6 +1760,9 @@ static struct notifier_block xen_hvm_cpu_notifier = {
static void __init xen_hvm_guest_init(void)
{
+ if (xen_pv_domain())
+ return;
+
I take Andy's point that this looks a little odd, perhaps...

static void __init xen_platform_init(void)
{
if (!xen_pv_domain())
xen_hvm_guest_init();
}

Would be a useful follow up?

I'll apply as-is though



Yes, this would look better. I can respin this if you want to avoid the extra patch.

-boris
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/