Re: Patch breaks suspend

From: Rafael J. Wysocki
Date: Tue May 05 2015 - 07:50:01 EST


On Tuesday, May 05, 2015 11:38:50 AM Marian Marinov wrote:
> On 05/05/2015 02:37 AM, Rafael J. Wysocki wrote:
> > On Saturday, May 02, 2015 11:27:32 PM Marian Marinov wrote:
> >> Hi guys,
> >> I have Lenovo T520 with one SSD and one SATA drive.
> >>
> >> I tried to upgrade to Linux 4.0 and found that after suspend and resume I can't access the second (SATA) drive.
> >> Both drives have bios encryption enabled.
> >>
> >> I did a bisect and found that the following patch causes the issue:
> >> commit 5d5132059a1f652de9dc2d62a8ff15561e648d11
> >> Author: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx>
> >> Date: Sat Feb 22 00:48:31 2014 +0100
> >>
> >> ACPI / ATA: Add hotplug contexts to ACPI companions of SATA devices
> >>
> >> Modify the SATA subsystem to add hotplug contexts to ACPI companions
> >> of SATA devices and ports instead of registering special ACPI dock
> >> operations using register_hotplug_dock_device().
> >>
> >> That change will allow the entire code handling those special ACPI
> >> dock operations to be dropped in the next commit.
> >>
> >> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx>
> >> Reviewed-by: Aaron Lu <aaron.lu@xxxxxxxxx>
> >> Acked-by: Tejun Heo <tj@xxxxxxxxxx>
> >>
> >> Unfortunately I do not understand this part of the code and have no idea what I can do.
> >> Any pointers would be very appreciated.
> > Well, not right from the top of my head, but this looks really suspicious to me.
> >
> > Can you please file a bug entry for this at bugzilla.kernel.org (in the ACPI/BIOS
> > category), assign it to me and CC Aaron?
> BUG created: https://bugzilla.kernel.org/show_bug.cgi?id=97731
>
> Added you and Aaron to the CC list.
>
> What additional info can I provide you? Would you like any debug info from the kernel it self?
> Dmesg output?

Let's track this one in the BZ from now on if that's not a problem.


--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/