Re: [PATCH resend 3/5] xtensa: Provide dummy dma_alloc_attrs() and dma_free_attrs()

From: Chris Zankel
Date: Mon May 04 2015 - 18:35:52 EST


Hi Guenter,

Sorry for the delay. Will work on it later today or tomorrow.

Thanks,
-Chris


On Mon, May 4, 2015 at 3:30 PM, Guenter Roeck <linux@xxxxxxxxxxxx> wrote:
> xtensa:allmodconfig fails to build with the following errors.
>
> drivers/gpu/drm/nouveau/nvkm/subdev/instmem/gk20a.c:
> In function âgk20a_instobj_dtor_dmaâ:
> drivers/gpu/drm/nouveau/nvkm/subdev/instmem/gk20a.c:154:2: error:
> implicit declaration of function âdma_free_attrsâ
> drivers/gpu/drm/nouveau/nvkm/subdev/instmem/gk20a.c:
> In function âgk20a_instobj_ctor_dmaâ:
> drivers/gpu/drm/nouveau/nvkm/subdev/instmem/gk20a.c:218:2: error:
> implicit declaration of function âdma_alloc_attrsâ
>
> Xtensa does not provide those functions at this time.
> Provide dummy implementations to avoid build errors.
>
> Acked-by: Max Filippov <jcmvbkbc@xxxxxxxxx>
> Signed-off-by: Guenter Roeck <linux@xxxxxxxxxxxx>
> ---
> Please consider pushing this patch into mainline, or provide feedback
> on how to improve it to be acceptable.
>
> arch/xtensa/include/asm/dma-mapping.h | 13 +++++++++++++
> 1 file changed, 13 insertions(+)
>
> diff --git a/arch/xtensa/include/asm/dma-mapping.h b/arch/xtensa/include/asm/dma-mapping.h
> index 172a02a6ad14..ba78ccf651e7 100644
> --- a/arch/xtensa/include/asm/dma-mapping.h
> +++ b/arch/xtensa/include/asm/dma-mapping.h
> @@ -185,4 +185,17 @@ static inline int dma_get_sgtable(struct device *dev, struct sg_table *sgt,
> return -EINVAL;
> }
>
> +static inline void *dma_alloc_attrs(struct device *dev, size_t size,
> + dma_addr_t *dma_handle, gfp_t flag,
> + struct dma_attrs *attrs)
> +{
> + return NULL;
> +}
> +
> +static inline void dma_free_attrs(struct device *dev, size_t size,
> + void *vaddr, dma_addr_t dma_handle,
> + struct dma_attrs *attrs)
> +{
> +}
> +
> #endif /* _XTENSA_DMA_MAPPING_H */
> --
> 2.1.0
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/