Re: [PATCH] block: pmem: Add dependency on HAS_IOMEM

From: Ross Zwisler
Date: Mon May 04 2015 - 16:00:54 EST


On Mon, 2015-05-04 at 20:58 +0200, Richard Weinberger wrote:
> Not all architectures have io memory.
>
> Fixes:
> drivers/block/pmem.c: In function âpmem_allocâ:
> drivers/block/pmem.c:146:2: error: implicit declaration of function âioremap_nocacheâ [-Werror=implicit-function-declaration]
> pmem->virt_addr = ioremap_nocache(pmem->phys_addr, pmem->size);
> ^
> drivers/block/pmem.c:146:18: warning: assignment makes pointer from integer without a cast [enabled by default]
> pmem->virt_addr = ioremap_nocache(pmem->phys_addr, pmem->size);
> ^
> drivers/block/pmem.c:182:2: error: implicit declaration of function âiounmapâ [-Werror=implicit-function-declaration]
> iounmap(pmem->virt_addr);
> ^
>
> Signed-off-by: Richard Weinberger <richard@xxxxxx>
> ---
> drivers/block/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/block/Kconfig b/drivers/block/Kconfig
> index eb1fed5..3ccef9e 100644
> --- a/drivers/block/Kconfig
> +++ b/drivers/block/Kconfig
> @@ -406,6 +406,7 @@ config BLK_DEV_RAM_DAX
>
> config BLK_DEV_PMEM
> tristate "Persistent memory block device support"
> + depends on HAS_IOMEM
> help
> Saying Y here will allow you to use a contiguous range of reserved
> memory as one or more persistent block devices.

Reviewed-by: Ross Zwisler <ross.zwisler@xxxxxxxxxxxxxxx>


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/