Re: [PATCH] x86/earlyprintk: setup earlyprintk as early as possible

From: Yinghai Lu
Date: Tue Apr 07 2015 - 15:08:42 EST


On Tue, Apr 7, 2015 at 12:07 PM, Yinghai Lu <yinghai@xxxxxxxxxx> wrote:
> On Tue, Apr 7, 2015 at 3:31 AM, Alexander Kuleshov
> <kuleshovmail@xxxxxxxxx> wrote:
>
>>
>> As i already wrote, i tested it for x86_64 and it works. I will put earlyprintk
>> setup in the start of the i386_start_kernel, will test it with 32-bit
>> and resend two
>> patches if they will be good.
>
> No, that is not enough.
> early_printk would handle not only serial console with io port accessing.
> You need to make sure all other path including pciserial/dbgp/efi is safe.
> They are using early_ioremap, and you can not call early_ioremap()
> before early_ioremap.

They are using early_ioremap, and you can not call early_ioremap()
before early_ioremap_init.

>
> otherwise you may need to just search "serial string in boot command line" like
> i did in moving earlycon early patch.
>
> Yinghai
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/