Re: [Linux-nvdimm] [PATCH 1/2] x86: add support for the non-standard protected e820 type

From: Toshi Kani
Date: Mon Apr 06 2015 - 14:41:33 EST


On Mon, 2015-04-06 at 11:26 -0700, Yinghai Lu wrote:
> On Mon, Apr 6, 2015 at 10:29 AM, Toshi Kani <toshi.kani@xxxxxx> wrote:
> > On Sat, 2015-04-04 at 11:40 +0200, Ingo Molnar wrote:
>
> > OK, I will send a patch for the fix, with suggested update from
> > Christoph of not to re-add 'type' argument to e820_end_pfn().
> >
> > Yinghai, I will add your sign-off to the patch. Let me know if you have
> > any concern.
>
> I think we should restore all to original.
>
> e820_end_pfn(unsigned long limit_pfn, unsigned type)
> e820_end_of_ram_pfn
> e820_end_of_low_ram_pfn
>
> otherwise it will cause confusing, because last two really have ram_pfn,
> and the first one does not has ram in the function name.

Good point. I will revert back to the original.

Thanks,
-Toshi


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/