Re: [PATCH] MAINTAINERS: Add me on list of Dell laptop drivers

From: Pali RohÃr
Date: Sun Apr 05 2015 - 17:12:09 EST


On Thursday 02 April 2015 07:10:27 Darren Hart wrote:
> On Sun, Mar 29, 2015 at 03:38:50PM +0200, Pali RohÃr wrote:
>
> Please include why. No empty commit messages please.
>
> For example, you've written nearly a third of the dell-wmi.c
> driver, and all the dell-smo8800.c driver.
>

Ok. If you need description include this:

===
MAINTAINERS: Add me on list of Dell laptop drivers

I have written more parts of dell laptop drivers dell-laptop.c,
dell-wmi.c and dell-smo8800.c
===

> Dell Laptop is still pending the keyboard backlight patches
> though I believe (have I missed them?), so you don't
> currently have code ownership there. I agree you should be on
> the MAINTAINERS list, but it would be good to get your
> keyboard backlight changes in first.
>

ok.

> Gosh... sure seems like we should have merged that already...
> am I missing something? The last thing I see in master,
> testing, and next is the revert from Jan 21....
>

backlight support was merged for 3.19, but has small problem with
ALS settings. And then you decided to revert it for 3.19. After
that problem was fixed and last (2015-03-06) you wrote that you
queued patch again for 4.1 release.

> Also, Matthew, you're the listed maintainer for these, do you
> agree to adding Pali?
>
> > Signed-off-by: Pali RohÃr <pali.rohar@xxxxxxxxx>
> > ---
> >
> > MAINTAINERS | 7 +++++++
> > 1 file changed, 7 insertions(+)
> >
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index 88c09ca..72a08ef 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -3058,10 +3058,16 @@ F: drivers/net/fddi/defxx.*
> >
> > DELL LAPTOP DRIVER
> > M: Matthew Garrett <mjg59@xxxxxxxxxxxxx>
> >
> > +M: Pali RohÃr <pali.rohar@xxxxxxxxx>
> >
> > L: platform-driver-x86@xxxxxxxxxxxxxxx
> > S: Maintained
> > F: drivers/platform/x86/dell-laptop.c
> >
> > +DELL LAPTOP FREEFALL DRIVER
> > +M: Pali RohÃr <pali.rohar@xxxxxxxxx>
> > +S: Maintained
> > +F: drivers/platform/x86/dell-smo8800.c
> > +
> >
> > DELL LAPTOP SMM DRIVER
> > M: Guenter Roeck <linux@xxxxxxxxxxxx>
> > S: Maintained
> >
> > @@ -3076,6 +3082,7 @@ F: drivers/firmware/dcdbas.*
> >
> > DELL WMI EXTRAS DRIVER
> > M: Matthew Garrett <mjg59@xxxxxxxxxxxxx>
> >
> > +M: Pali RohÃr <pali.rohar@xxxxxxxxx>
> >
> > S: Maintained
> > F: drivers/platform/x86/dell-wmi.c

--
Pali RohÃr
pali.rohar@xxxxxxxxx

Attachment: signature.asc
Description: This is a digitally signed message part.