Re: [PATCH v2] crypto: omap-sham: Add the offset of sg page to vaddr

From: Herbert Xu
Date: Fri Apr 03 2015 - 06:00:35 EST


On Thu, Apr 02, 2015 at 03:32:45PM +0530, Lokesh Vutla wrote:
> kmap_atomic() gives only the page address of the input page.
> Driver should take care of adding the offset of the scatterlist
> within the page to the returned page address.
> omap-sham driver is not adding the offset to page and directly operates
> on the return vale of kmap_atomic(), because of which the following
> error comes when running crypto tests:
>
> 00000000: d9 a1 1b 7c aa 90 3b aa 11 ab cb 25 00 b8 ac bf
> [ 2.338169] 00000010: c1 39 cd ff 48 d0 a8 e2 2b fa 33 a1
> [ 2.344008] alg: hash: Chunking test 1 failed for omap-sha256
>
> So adding the scatterlist offset to vaddr.
>
> Signed-off-by: Lokesh Vutla <lokeshvutla@xxxxxx>

Patch applied. Thanks!
--
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/