Re: [PATCH] mvneta: implement SGMII-based in-band link state signaling

From: David Miller
Date: Thu Apr 02 2015 - 20:51:39 EST


From: Stas Sergeev <stsp@xxxxxxx>
Date: Tue, 31 Mar 2015 16:24:59 +0300

> @@ -2590,6 +2651,7 @@ static int mvneta_mdio_probe(struct mvneta_port *pp)
>
> static void mvneta_mdio_remove(struct mvneta_port *pp)
> {
> + fixed_phy_set_link_update(pp->phy_dev, NULL);

I do not see any other driver doing this on shutdown.
Please show me why it is necessary.

And if it is, all other drivers registering a fixed phy link update
function need to be adjusted to do the same thing.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/