Re: [PATCH v2.1] ftracetest: Do not use usleep directly

From: Shuah Khan
Date: Thu Apr 02 2015 - 10:20:18 EST


On 04/02/2015 07:38 AM, Steven Rostedt wrote:
> On Thu, 02 Apr 2015 14:58:04 +0900
> Masami Hiramatsu <masami.hiramatsu.pt@xxxxxxxxxxx> wrote:
>
>> (2015/04/02 13:34), Namhyung Kim wrote:
>>> The usleep is only provided on distros from Redhat so running ftracetest
>>> on other distro resulted in failures due to the missing usleep.
>>>
>>> The reason of using [u]sleep in the test was to generate (scheduler)
>>> events. It can be done various ways like this:
>>>
>>> yield() { ping localhost -c 1 || sleep .001 || usleep 1 || sleep 1; }
>>
>> Nice hack! :)
>
> Yep, it was PÃdraig Brady's idea.
>
>>
>> Acked-by: Masami Hiramatsu <masami.hiramatsu.pt@xxxxxxxxxxx>
>
> Acked-by: Steven Rostedt <rostedt@xxxxxxxxxxx>
>
> -- Steve
>
>>
>>>
>>> Reported-by: Michael Ellerman <mpe@xxxxxxxxxxxxxx>
>>> Reported-by: Dave Jones <davej@xxxxxxxxxxxxxxxxx>
>>> Reported-by: Luis Henriques <luis.henriques@xxxxxxxxxxxxx>
>>> Based-on-patch-by: PÃdraig Brady <P@xxxxxxxxxxxxxx>

Is this standard? checkpatch complained as non-standard. I am
seeing some patches posted with Based-on-patch-by

Anyway, I have this patch tagged for 4.1-rc2

thanks,
-- Shuah

--
Shuah Khan
Sr. Linux Kernel Developer
Open Source Innovation Group
Samsung Research America (Silicon Valley)
shuahkh@xxxxxxxxxxxxxxx | (970) 217-8978
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/