RE: [PATCH v1 1/2] mfd/axp20x: add support for extcon cell

From: Pallala, Ramakrishna
Date: Thu Apr 02 2015 - 06:57:11 EST


> > > > diff --git a/include/linux/mfd/axp20x.h
> > > > b/include/linux/mfd/axp20x.h index dfabd6d..4ed8071 100644
> > > > --- a/include/linux/mfd/axp20x.h
> > > > +++ b/include/linux/mfd/axp20x.h
> > > > @@ -275,4 +275,9 @@ struct axp20x_fg_pdata {
> > > > int thermistor_curve[MAX_THERM_CURVE_SIZE][2];
> > > > };
> > > >
> > > > +struct axp288_extcon_pdata {
> > > > + /* GPIO pin control to switch D+/D- lines b/w PMIC and SOC */
> > > > + struct gpio_desc *gpio_mux_cntl; };
> > >
> > > This chunk of code is unrelated to this patch.
> > As it's axp20x.h file change I added it here...if you donât feel logical to have it
> in the patch I can move this to patch 2/2.
>
> You should add it to the patch that first uses it.
Ok I will fix it.

Thanks,
Ram