Re: [PATCH] ext3: Remove useless condition in if statement.

[Jan Kara]

On Mon 23-03-15 11:30:44, LukÃÅ Czerner wrote:
> On Fri, 20 Mar 2015, Wei Yuan wrote:
> 
> > Date: Fri, 20 Mar 2015 11:09:10 +0800
> > From: Wei Yuan <weiyuan.wei@xxxxxxxxxx>
> > To: jack@xxxxxxx, akpm@xxxxxxxxxxxxxxxxxxxx, adilger.kernel@xxxxxxxxx
> > Cc: linux-ext4@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx,
> >     lczerner@xxxxxxxxxx, lizefan@xxxxxxxxxx
> > Subject: [PATCH] ext3: Remove useless condition in if statement.
> > 
> > In this if statement, the previous condition is useless, the later one has covered it.
> 
> Nice that you've send this ext3 counterpart for ext4 patch. Thanks!
> 
> Reviewed-by: Lukas Czerner <lczerner@xxxxxxxxxx>
  Thanks. I've added the patch to my tree.

								Honza

> 
> > 
> > Signed-off-by: Weiyuan <weiyuan.wei@xxxxxxxxxx>
> > ---
> >  fs/ext3/xattr.c | 3 +--
> >  1 file changed, 1 insertion(+), 2 deletions(-)
> > 
> > diff --git a/fs/ext3/xattr.c b/fs/ext3/xattr.c
> > index c6874be..24215dc 100644
> > --- a/fs/ext3/xattr.c
> > +++ b/fs/ext3/xattr.c
> > @@ -546,8 +546,7 @@ ext3_xattr_set_entry(struct ext3_xattr_info *i, struct ext3_xattr_search *s)
> >  		free += EXT3_XATTR_LEN(name_len);
> >  	}
> >  	if (i->value) {
> > -		if (free < EXT3_XATTR_SIZE(i->value_len) ||
> > -		    free < EXT3_XATTR_LEN(name_len) +
> > +		if (free < EXT3_XATTR_LEN(name_len) +
> >  			   EXT3_XATTR_SIZE(i->value_len))
> >  			return -ENOSPC;
> >  	}
> > 
-- 
Jan Kara <jack@xxxxxxx>
SUSE Labs, CR
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/