Re: [rtc-linux] Re: [PATCH 3/3] rtc: hctosys: use function name in the error log

[Alessandro Zummo]

On Tue, 31 Mar 2015 20:18:28 -0700
Joe Perches <joe@xxxxxxxxxxx> wrote:

> Neither __func__ or __FILE__ is really useful here.
> The message is already specific enough without it.
> 
> If anything, it'd probably be better to add
> 
> #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt

 Seems reasonable given that pr_fmt is widely
 used elsewhere.

 I don't like too much the need to have one define for
 each file, but it's the way it works :-/

-- 

 Best regards,

 Alessandro Zummo - CEO,
  Tower Technologies - Torino, Italy

  http://www.towertech.it

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/