Re: [PATCH V2] Staging: rtl8192 Clean up function definition

From: Eddie Kovsky
Date: Tue Mar 31 2015 - 15:25:22 EST


On Tue, Mar 31, 2015 at 10:14:54AM +0300, Dan Carpenter wrote:
> On Mon, Mar 30, 2015 at 05:05:36PM -0600, Eddie Kovsky wrote:
> > Change function definition to static, move the function further up in
> > the file, and delete the function prototype.
> >
> > This fixes the following warning generated by sparse:
> >
> > drivers/staging/rtl8192u/r8192U_core.c:1970:6: warning: symbol
> > 'rtl8192_update_ratr_table' was not declared. Should it be static?
> >
>
> Someone already fixed the warning earlier but this this is still a nice
> patch to have.
>
> regards,
> dan carpenter
Dan

I sent in the patch last week to fix this warning. You had asked me to
clean up the function by removing the prototype instead. Greg had
already sent me a message saying he picked up that patch. I waited a few
cycles, but I still haven't seen my patch show up in yesterday's (or
today's) next.

I assume my original patch got dropped waiting on this one?

Eddie
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/