Re: [RFC] [PATCH 0/7] fs: add blkdev name format specifier

From: Jens Axboe
Date: Tue Mar 31 2015 - 12:43:15 EST


On 03/31/2015 10:01 AM, Dmitry Monakhov wrote:
Currently in order to print block_device name one should use blkdev() helper
which requires temproral buffer of size BDEVNAME_SIZE (32bytes). This is very
ineffective because result in stack usage bloating for deep IO call traces where
stack usage is close to maximum values.

It is reasonable to introduce dedicated format specifier for block_device name,
unfortunately "%pb", "%pB", "%pd" and "%pD" are already reserved for other data types
I've pick "%pg" ala geometry. If some one want to offer sane spacifier name
please let me know.

Since this is RFC version I've pick rough patch split policy (based on subsystem).
Please let me know if patchset should be split in different way.

I think this is looks good, nice improvement. I can take the lib and block parts, Al can pick up the fs bits.

--
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/