Re: [BUG] perf script segfault

[Jiri Olsa]

On Tue, Mar 31, 2015 at 01:14:20PM -0300, Arnaldo Carvalho de Melo wrote:
> Em Tue, Mar 31, 2015 at 05:50:48PM +0200, Jiri Olsa escreveu:
> > On Tue, Mar 31, 2015 at 05:48:44PM +0200, Jiri Olsa wrote:
> > > On Tue, Mar 31, 2015 at 11:57:39AM -0300, Arnaldo Carvalho de Melo wrote:
> > > 
> > > SNIP
> > > 
> > > >  	struct ordered_events *oe = &session->ordered_events;
> > > > -	struct perf_tool *tool = oe->tool;
> > > > +	struct perf_tool *tool = session->tool;
> > > >  	int fd = perf_data_file__fd(session->file);
> > > >  	u64 head, page_offset, file_offset, file_pos, size;
> > > >  	int err, mmap_prot, mmap_flags, map_idx = 0;
> > > > @@ -1394,6 +1407,7 @@ out:
> > > >  out_err:
> > > >  	ui_progress__finish();
> > > >  	perf_tool__warn_about_errors(tool, &session->evlist->stats);
> > > > +	ordered_events__warn_about_errors(&session->ordered_events);
> > > 
> > > how about just single warning function ?
> > > 
> > >   perf_session__warn_about_errors(struct perf_session *session)
> > > 
> > > session has now both tool and ordered_events
> > 
> > other than this it looks ok to me
> 
> Like this? If so, can I have your Acked-by? :-)

I luv it! ;-) thanks

Acked-by: Jiri Olsa <jolsa@xxxxxxxxxx>

jirka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/