Re: [PATCH v2 0/1] spi: Add driver for Routerboard RB4xx boards

From: Ralf Baechle
Date: Tue Mar 31 2015 - 10:27:48 EST


On Tue, Mar 31, 2015 at 09:44:25AM +0100, Mark Brown wrote:

> On Mon, Mar 30, 2015 at 08:24:16PM +0200, Bert Vermeulen wrote:
> > Changes in v2:
> > This is a near complete rewrite of the original OpenWrt driver. All comments
> > were taken into account, and the spi_transfer.fast_write flag is gone.
> > Instead, the cs_change flag is used. It's not too bad a hack, as it really
> > does use CS.
>
> Don't send cover letters for single patches, if there's anything that
> needs saying it should either be in the changelog or after the ---. A
> separate cover letter adds to the mail volume and probably means that
> the patch itself is inadequately described.

My personal grief with cover letters is that patchwork only collects
patches but cover letters themselves aren't patches. Which means working
through patchwork I might miss important information. Maybe I should
request an enhancement to patchwork.

Ralf
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/