Re: [PATCH] dmaengine: pl330: fix the race condition in pl330 driver.

From: Vinod Koul
Date: Mon Mar 30 2015 - 13:30:13 EST


On Mon, Mar 30, 2015 at 10:17:17PM +0530, Jassi Brar wrote:
> On Fri, Mar 27, 2015 at 5:25 AM, Scott Branden <sbranden@xxxxxxxxxxxx> wrote:
> > From: ismail <ismail@xxxxxxxxxxxx>
> >
> > Update the thread running index before issuing the
> > GO command to the DMAC.
> >
> > Tested-by: Mohamed Ismail Abdul Packir Mohamed <ismail@xxxxxxxxxxxx>
> > Reviewed-by: Ray Jui <rjui@xxxxxxxxxxxx>
> > Reviewed-by: Arun Parameswaran <aparames@xxxxxxxxxxxx>
> > Reviewed-by: Scott Branden <sbranden@xxxxxxxxxxxx>
> > Signed-off-by: Scott Branden <sbranden@xxxxxxxxxxxx>
> > Signed-off-by: Mohamed Ismail Abdul Packir Mohamed <ismail@xxxxxxxxxxxx>
> > ---
> > drivers/dma/pl330.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/dma/pl330.c b/drivers/dma/pl330.c
> > index 0e1f567..631642d 100644
> > --- a/drivers/dma/pl330.c
> > +++ b/drivers/dma/pl330.c
> > @@ -1072,11 +1072,11 @@ static bool _trigger(struct pl330_thread *thrd)
> > /* Set to generate interrupts for SEV */
> > writel(readl(regs + INTEN) | (1 << thrd->ev), regs + INTEN);
> >
> > + thrd->req_running = idx;
> > +
> > /* Only manager can execute GO */
> > _execute_DBGINSN(thrd, insn, true);
> >
> > - thrd->req_running = idx;
> > -
> It would help to know what the behavior looks like before and after
> the patch. If anything we should look at locking rather the
> reordering.
Yes that ia fair request, looking at changelog it is hard to understand the
issue seen?

--
~Vinod

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/