Re: [PATCH 10/11] clocksource: flexcard: Add basic timestamp counter support

From: Holger Dengler
Date: Fri Mar 27 2015 - 08:28:07 EST


Hi John,

On 03/26/2015 05:34 PM, John Stultz wrote:
> On Thu, Mar 26, 2015 at 4:01 AM, Holger Dengler <dengler@xxxxxxxxxxxxx> wrote:
>> On 03/26/2015 10:41 AM, Daniel Lezcano wrote:
>>>
>>> config CLKSRC_FLEXCARD
>>> bool
>>> select CLKSRC_MMIO
>>
>> The Flexcard PMC II, which provides this clocksrc functionality, is a
>> PCI card. According to the PMC specs, this card-type is hot-plugable. So
>> this clocksrc is not SoC-related, it's also hot-plugable.
>> Therefore a module-capable driver seems a good solution for me.
>>
>>>
>>> and then the Kconfig for MFD_FLEXCARD selects CLKSRC_FLEXCARD.
>>>
>>
>> Ok, this could be an option to enable the clocksrc feature by default,
>> if MFD_FLEXCARD is selected.
>
> Yea, I think this would be preferred. If the user already selects
> something to get device functionality, lets not make them search
> around in other menus to find another config option to enable all the
> capabilities.

We integrated the "MFD_FLEXCARD selects CLKSRC_FLEXCARD". If we get some
responces as well for the other parts of this patchset, we'll resend it
with the modifications.

>
> thanks
> -john
>

Kind regards,
Holger Dengler
--
phone: +49 7556 45 218 94; fax: +49 7556 91 98 86
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/