Re: [PATCH] x86/apic: remove read/write test in verify_local_apic()

From: Ingo Molnar
Date: Fri Mar 27 2015 - 08:11:11 EST



* Bandan Das <bsd@xxxxxxxxxx> wrote:

>
> Most newer processors have the APIC_ID read-only and this
> test probably fails on most boxes anyway. Fix typos.
>
> Signed-off-by: Bandan Das <bsd@xxxxxxxxxx>
> ---
> Honestly, I don't think this function is really needed.
> It's called for both UP/MP but the return value isn't
> used by any of them. Maybe, we should just remove it ?

Agreed, lets just remove it.

Thanks,

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/