Re: [V6 PATCH 2/3] ACPI / scan: Add support for ACPI _CLS device matching
From: Suravee Suthikulpanit
Date: Thu Mar 26 2015 - 10:40:03 EST
On 3/26/15 05:29, Mika Westerberg wrote:
On Wed, Mar 25, 2015 at 03:46:07PM -0500, Suravee Suthikulpanit wrote:
[...]
diff --git a/include/linux/mod_devicetable.h b/include/linux/mod_devicetable.h
index e530533..9563abe 100644
--- a/include/linux/mod_devicetable.h
+++ b/include/linux/mod_devicetable.h
@@ -189,8 +189,12 @@ struct css_device_id {
struct acpi_device_id {
__u8 id[ACPI_ID_LEN];
kernel_ulong_t driver_data;
+ __u32 cls;
+ __u32 cls_msk;
};
+#define ACPI_DEVICE_CLASS(cls, msk) "", 0, cls, msk
Consider moving this to <linux/acpi.h>, just like PCI_DEVICE_CLASS() is
defined in <linux/pci.h>.
Also please use designated initializers here, eg:
#define ACPI_DEVICE_CLASS(cls, msk) .cls = (cls), .cls_mask = (msk)
Once done you can add my,
Acked-by: Mika Westerberg <mika.westerberg@xxxxxxxxxxxxxxx>
Ah right. I should have done that. I'll send out V7 with this change and
acked-by.
Thanks,
Suravee
+
#define PNP_ID_LEN 8
#define PNP_MAX_DEVICES 8
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/