Re: [PATCH v4 00/17] media: blackfin: bfin_capture enhancements

From: Scott Jiang
Date: Thu Mar 26 2015 - 05:18:48 EST


Hi Lad and Hans,

2015-03-08 22:40 GMT+08:00 Lad Prabhakar <prabhakar.csengg@xxxxxxxxx>:
> From: "Lad, Prabhakar" <prabhakar.csengg@xxxxxxxxx>
>
> This patch series, enhances blackfin capture driver with
> vb2 helpers.
>
> Changes for v4:
> 1: Improved commit message for path 4/17 and 5/17.
> 2: Added Ack's from Scott to patches 1-15
> 3: Two new patches 16/17 and 17/17
>
> Lad, Prabhakar (17):
> media: blackfin: bfin_capture: drop buf_init() callback
> media: blackfin: bfin_capture: release buffers in case
> start_streaming() call back fails
> media: blackfin: bfin_capture: set min_buffers_needed
> media: blackfin: bfin_capture: set vb2 buffer field
> media: blackfin: bfin_capture: improve queue_setup() callback
> media: blackfin: bfin_capture: use vb2_fop_mmap/poll
> media: blackfin: bfin_capture: use v4l2_fh_open and vb2_fop_release
> media: blackfin: bfin_capture: use vb2_ioctl_* helpers
> media: blackfin: bfin_capture: make sure all buffers are returned on
> stop_streaming() callback
> media: blackfin: bfin_capture: return -ENODATA for *std calls
> media: blackfin: bfin_capture: return -ENODATA for *dv_timings calls
> media: blackfin: bfin_capture: add support for vidioc_create_bufs
> media: blackfin: bfin_capture: add support for VB2_DMABUF
> media: blackfin: bfin_capture: add support for VIDIOC_EXPBUF
> media: blackfin: bfin_capture: set v4l2 buffer sequence
> media: blackfin: bfin_capture: drop bcap_get_unmapped_area()
> media: blackfin: bfin_capture: embed video_device struct in
> bcap_device
>
> drivers/media/platform/blackfin/bfin_capture.c | 348 ++++++++-----------------
> 1 file changed, 103 insertions(+), 245 deletions(-)
>

for patch 16/17,
Acked-by: Scott Jiang <scott.jiang.linux@xxxxxxxxx>
Tested-by: Scott Jiang <scott.jiang.linux@xxxxxxxxx>

Hans, I tried to use v4l2-compliance but it failed to compile. Sorry
for telling you it have passed compilation because I forgot to use
blackfin toolchain.
./configure --without-jpeg --host=bfin-linux-uclibc --disable-libv4l

The main problem is there is no argp.h in uClibc, how to disable checking this?

checking for argp.h... no
configure: error: Cannot continue: argp.h not found

Scott
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/