Re: [PATCH v3 1/9] regmap: Introduce regmap_get_max_register.

From: Mark Brown
Date: Tue Mar 24 2015 - 18:36:34 EST


On Tue, Mar 24, 2015 at 10:29:39PM +0000, Srinivas Kandagatla wrote:

> This patch introduces regmap_get_max_register() function which would be
> used by the infrastructures like eeprom framework built on top of
> regmap.

In what way would it be used?

> +int regmap_get_max_register(struct regmap *map)
> +{
> + return map->max_register ? : -EINVAL;
> +}

Please write the logic out properly, don't abuse the ternery operator.

Attachment: signature.asc
Description: Digital signature