Re: [PATCH v3 0/4] input: ft5x06: Fix userspace reported maximum value

From: Dmitry Torokhov
Date: Tue Mar 24 2015 - 14:56:25 EST


On Tue, Mar 24, 2015 at 11:45:20AM -0700, Maxime Ripard wrote:
> On Tue, Mar 24, 2015 at 09:47:22AM -0700, Dmitry Torokhov wrote:
> > On Mon, Mar 23, 2015 at 05:10:02PM -0700, Maxime Ripard wrote:
> > > Hi Lothar, Dmitry,
> > >
> > > On Tue, Mar 03, 2015 at 02:50:42PM +0100, Maxime Ripard wrote:
> > > > Hi,
> > > >
> > > > The current ft5x06 reports to the user-space that its maximum
> > > > coordinates are, on both X and Y, way higher than what could be
> > > > actually usable on the screen (in my case, 5759x1151 instead of
> > > > 480x800).
> > > >
> > > > This causes trouble on some userspace stacks that then try to re-scale
> > > > these coordinates back to the framebuffer resolution, like QT does.
> > > >
> > > > Use the of_touchscreen code to find the real touchscreen limits in the
> > > > DT case, and report that to the userspace.
> > >
> > > Do you have any comments on that?
> >
> > Yes, I'll apply it, although if you could supply the updated patch
> > description for #1 that would be great. The current one seems from the
> > old version and is no longer accurate.
> >
> > Thanks.
>
> You're right.
>
> Would something like:
>
> """
> input: touchscreen: of: Rework the DT parsing function
>
> The DT parsing function currently duplicates a lot of the code to
> parse the touchscreen DT properties.
>
> In order to ease further additions to this parsing routine, rework it
> slightly to create new helper functions.
>
> Signed-off-by: Maxime Ripard <maxime.ripard@xxxxxxxxxxxxxxxxxx>
> """
>
> be good enough?

Yep, thanks, I'll update the description, consider applied.

Thanks.

--
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/