Re: [PATCH 2/2] EDMA: TI: fixed wrongly initialized data parameter to the edma callback

[Peter Ujfalusi]

On 03/23/2015 10:35 PM, Petr Kulhavy wrote:
> The "data" parameter passed indirectly to the edma_callback() should be
> edma_chan and not the dma_chan.
> 
> This bug was so far harmless since the offset of struct dma_chan within struct
> edma_chan is 0. However as soon as someone changes struct edma_chan this would
> cause troubles.

Good catch. This seams to be in the code since the first commit ;)

Acked-by: Peter Ujfalusi <peter.ujfalusi@xxxxxx>

> Signed-off-by: Petr Kulhavy <petr@xxxxxxxxx>
> ---
>  drivers/dma/edma.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/dma/edma.c b/drivers/dma/edma.c
> index 1465610..4c8208b 100644
> --- a/drivers/dma/edma.c
> +++ b/drivers/dma/edma.c
> @@ -813,7 +813,7 @@ static int edma_alloc_chan_resources(struct dma_chan *chan)
>  	LIST_HEAD(descs);
>  
>  	a_ch_num = edma_alloc_channel(echan->ch_num, edma_callback,
> -					chan, EVENTQ_DEFAULT);
> +					echan, EVENTQ_DEFAULT);
>  
>  	if (a_ch_num < 0) {
>  		ret = -ENODEV;
> 


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/