Re: [PATCH net-next V2 19/23] ptp: tilegx: convert to the 64 bit get/set time methods.

[Chris Metcalf]

On 03/21/2015 05:39 PM, Richard Cochran wrote:
> This driver calls code (via gxio_mpipe_get/set_timestamp) that makes
> the assumption that the tv_sec field is 64 bits wide.  So apparently
> this driver is 64 bit only.  So maybe this driver and device are ready
> for 2038, but maybe not.
>
> Not even compile tested.
>
> Signed-off-by: Richard Cochran<richardcochran@xxxxxxxxx>

This driver is 64-bit only.  Would it make more sense to just change
the accessors from gettime/settime to gettime/settime64 and nothing
else, i.e. rely on the current behavior that timespec and timespec64
are the same type, and trust the compiler to fail it if somehow someone
tried to build this driver into a 32-bit kernel?

In any case, if you think it's better as-is, you can certainly have my

Acked-by: Chris Metcalf <cmetcalf@xxxxxxxxxx>

--
Chris Metcalf, EZChip Semiconductor
http://www.ezchip.com

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/