Re: [PATCH net-next V2 20/23] ptp: dp83640: convert to the 64 bit get/set time methods.

[Arnd Bergmann]

On Monday 23 March 2015, Richard Cochran wrote:
> 
> On Sun, Mar 22, 2015 at 06:48:02PM +0100, Arnd Bergmann wrote:
> > Ok, got it. The code looks correct then, though I'd like to see the use
> > of 'timespec' pushed out as far as possible. How about changing the
> > type for tdr_write() as well here?
> > 
> > tdr_write() itself should be fine until 2106, as it writes an unsigned number,
> > but it's probably good to document that inside of that function.
> 
> Arnd, thanks for the careful review.  I will work out follow up
> patches for this driver and the i210 (igb) to address the remaining
> issues.  For this series, lets leave tdr_write as is now, but I will
> surely take another look for the fix.
> 

Ok, sounds good.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/