Re: [PATCH v1 04/11] stm class: stm_console: Add kernel-console-over-stm driver

From: Paul Bolle
Date: Sat Mar 21 2015 - 07:59:30 EST


All I spotted is two nits.

On Fri, 2015-03-20 at 19:29 +0200, Alexander Shishkin wrote:
> +config STM_SOURCE_CONSOLE
> + tristate "Kernel console over STM devices"

Tab instead of eight spaces, please.

> + default N

You meant
default n

as n is a magic symbol. But n is the default anyway, so I think you
might as well drop this line.

> + help
> + This is a kernel space trace source that sends kernel log
> + messages to trace hosts over STM devices.
> +
> + If you want to send kernel console messages over STM devices,
> + say Y.


Paul Bolle

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/